server: fix pod retrieval during volume attach #10324

shwstppr · 2025-02-04T10:35:40Z

Description

Includes changes from #10267 as they've been reverted by #10323

Fixes issue highlighted in #9315 (comment)

A volume in Allocated state can be attached to a stopped VM even when the actual volume is not created in the primary store.
test_12_start_vm_multiple_volumes_allocated in test/integration/smoke/test_vm_life_cycle.py does the same.
After changes in #10267, a scenario was failing as a suitable pool was not found for an allocated volume when attached to a VM which has never been started

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Verified test_vm_life_cycle.py with changes,

[root@pr9315-t7075-kvm-rocky8-marvin marvin]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./pr9315-t7075-kvm-rocky8-advanced-cfg -s -a tags=advanced --hypervisor=KVM tests/smoke/test_vm_life_cycle.py 
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:32: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography will remove support for Python 3.6.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Feb_05_2025_08_29_31_XD4RCY All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_advZoneVirtualRouter | Status : SUCCESS ===

=== TestName: test_deploy_vm | Status : SUCCESS ===

=== TestName: test_deploy_vm_multiple | Status : SUCCESS ===

=== TestName: test_01_migrate_VM_and_root_volume | Status : SUCCESS ===

=== TestName: test_02_migrate_VM_with_two_data_disks | Status : SUCCESS ===

Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: grep -a listen_tls=1 /etc/libvirt/libvirtd.conf | tail -1 via Host: 10.1.35.116} {returns: ['listen_tls=1']}
Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
=== TestName: test_01_secure_vm_migration | Status : SUCCESS ===

Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: rm -f /etc/cloudstack/agent/cloud* &&                       service cloudstack-agent stop ;                       service libvirtd stop ;                       service libvirt-bin stop ;                       sed -i 's/listen_tls.*/listen_tls=0/g' /etc/libvirt/libvirtd.conf &&                       sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf &&                       sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf &&                       sed -i 's/vnc_tls.*/vnc_tls=0/g' /etc/libvirt/qemu.conf &&                       service libvirtd start ;                       service libvirt-bin start ;                       sleep 30 ;                       service cloudstack-agent start via Host: 10.1.35.116} {returns: ['Redirecting to /bin/systemctl stop cloudstack-agent.service', 'Redirecting to /bin/systemctl stop libvirtd.service', 'Redirecting to /bin/systemctl stop libvirt-bin.service', 'Failed to stop libvirt-bin.service: Unit libvirt-bin.service not loaded.', 'Redirecting to /bin/systemctl start libvirtd.service', 'Redirecting to /bin/systemctl start libvirt-bin.service', 'Failed to start libvirt-bin.service: Unit libvirt-bin.service not found.', 'Redirecting to /bin/systemctl start cloudstack-agent.service']}
Unsecuring Host: pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
====Trying SSH Connection: Host:10.1.34.196 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.34.196 port : 22 SUCCESSFUL===
{Cmd: rm -f /etc/cloudstack/agent/cloud* &&                       service cloudstack-agent stop ;                       service libvirtd stop ;                       service libvirt-bin stop ;                       sed -i 's/listen_tls.*/listen_tls=0/g' /etc/libvirt/libvirtd.conf &&                       sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf &&                       sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf &&                       sed -i 's/vnc_tls.*/vnc_tls=0/g' /etc/libvirt/qemu.conf &&                       service libvirtd start ;                       service libvirt-bin start ;                       sleep 30 ;                       service cloudstack-agent start via Host: 10.1.34.196} {returns: ['Redirecting to /bin/systemctl stop cloudstack-agent.service', 'Redirecting to /bin/systemctl stop libvirtd.service', 'Redirecting to /bin/systemctl stop libvirt-bin.service', 'Failed to stop libvirt-bin.service: Unit libvirt-bin.service not loaded.', 'Redirecting to /bin/systemctl start libvirtd.service', 'Redirecting to /bin/systemctl start libvirt-bin.service', 'Failed to start libvirt-bin.service: Unit libvirt-bin.service not found.', 'Redirecting to /bin/systemctl start cloudstack-agent.service']}
Unsecuring Host: pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: grep -a listen_tcp=1 /etc/libvirt/libvirtd.conf | tail -1 via Host: 10.1.35.116} {returns: ['listen_tcp=1']}
Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
=== TestName: test_02_unsecure_vm_migration | Status : SUCCESS ===

Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: rm -f /etc/cloudstack/agent/cloud* &&                       service cloudstack-agent stop ;                       service libvirtd stop ;                       service libvirt-bin stop ;                       sed -i 's/listen_tls.*/listen_tls=0/g' /etc/libvirt/libvirtd.conf &&                       sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf &&                       sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf &&                       sed -i 's/vnc_tls.*/vnc_tls=0/g' /etc/libvirt/qemu.conf &&                       service libvirtd start ;                       service libvirt-bin start ;                       sleep 30 ;                       service cloudstack-agent start via Host: 10.1.35.116} {returns: ['Redirecting to /bin/systemctl stop cloudstack-agent.service', 'Redirecting to /bin/systemctl stop libvirtd.service', 'Redirecting to /bin/systemctl stop libvirt-bin.service', 'Failed to stop libvirt-bin.service: Unit libvirt-bin.service not loaded.', 'Redirecting to /bin/systemctl start libvirtd.service', 'Redirecting to /bin/systemctl start libvirt-bin.service', 'Failed to start libvirt-bin.service: Unit libvirt-bin.service not found.', 'Redirecting to /bin/systemctl start cloudstack-agent.service']}
Unsecuring Host: pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
====Trying SSH Connection: Host:10.1.34.196 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.34.196 port : 22 SUCCESSFUL===
{Cmd: grep -a listen_tls=1 /etc/libvirt/libvirtd.conf | tail -1 via Host: 10.1.34.196} {returns: ['listen_tls=1']}
Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
=== TestName: test_03_secured_to_nonsecured_vm_migration | Status : SUCCESS ===

Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: rm -f /etc/cloudstack/agent/cloud* &&                       service cloudstack-agent stop ;                       service libvirtd stop ;                       service libvirt-bin stop ;                       sed -i 's/listen_tls.*/listen_tls=0/g' /etc/libvirt/libvirtd.conf &&                       sed -i 's/listen_tcp.*/listen_tcp=1/g' /etc/libvirt/libvirtd.conf &&                       sed -i '/.*_file=.*/d' /etc/libvirt/libvirtd.conf &&                       sed -i 's/vnc_tls.*/vnc_tls=0/g' /etc/libvirt/qemu.conf &&                       service libvirtd start ;                       service libvirt-bin start ;                       sleep 30 ;                       service cloudstack-agent start via Host: 10.1.35.116} {returns: ['Redirecting to /bin/systemctl stop cloudstack-agent.service', 'Redirecting to /bin/systemctl stop libvirtd.service', 'Redirecting to /bin/systemctl stop libvirt-bin.service', 'Failed to stop libvirt-bin.service: Unit libvirt-bin.service not loaded.', 'Redirecting to /bin/systemctl start libvirtd.service', 'Redirecting to /bin/systemctl start libvirt-bin.service', 'Failed to start libvirt-bin.service: Unit libvirt-bin.service not found.', 'Redirecting to /bin/systemctl start cloudstack-agent.service']}
Unsecuring Host: pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
====Trying SSH Connection: Host:10.1.35.116 User:root                                   Port:22 RetryCnt:60===
===SSH to Host 10.1.35.116 port : 22 SUCCESSFUL===
{Cmd: grep -a listen_tcp=1 /etc/libvirt/libvirtd.conf | tail -1 via Host: 10.1.35.116} {returns: ['listen_tcp=1']}
Securing Host pr9315-t7075-kvm-rocky8-kvm1
Host 9ba61cf4-a8a2-4ad7-afe7-f421a58ce2dd now showing as Up
Securing Host pr9315-t7075-kvm-rocky8-kvm2
Host 82c7aff5-ead2-4576-ba98-bfc4cdd81f8b now showing as Up
=== TestName: test_04_nonsecured_to_secured_vm_migration | Status : SUCCESS ===

=== TestName: test_01_stop_vm | Status : SUCCESS ===

=== TestName: test_01_stop_vm_forced | Status : SUCCESS ===

=== TestName: test_02_start_vm | Status : SUCCESS ===

=== TestName: test_03_reboot_vm | Status : SUCCESS ===

=== TestName: test_04_reboot_vm_forced | Status : SUCCESS ===

=== TestName: test_06_destroy_vm | Status : SUCCESS ===

=== TestName: test_07_restore_vm | Status : SUCCESS ===

=== TestName: test_08_migrate_vm | Status : SUCCESS ===

=== TestName: test_09_expunge_vm | Status : SUCCESS ===

====Trying SSH Connection: Host:10.1.53.86 User:root                                   Port:22 RetryCnt:20===
===SSH to Host 10.1.53.86 port : 22 SUCCESSFUL===
{Cmd: mkdir -p /mnt/tmp via Host: 10.1.53.86} {returns: []}
{Cmd: mount -rt iso9660 /dev/vdc /mnt/tmp via Host: 10.1.53.86} {returns: ['mount: special device /dev/vdc does not exist']}
{Cmd: mount -rt iso9660 /dev/vdb /mnt/tmp via Host: 10.1.53.86} {returns: ['mount: special device /dev/vdb does not exist']}
{Cmd: mount -rt iso9660 /dev/hdb /mnt/tmp via Host: 10.1.53.86} {returns: ['mount: special device /dev/hdb does not exist']}
{Cmd: mount -rt iso9660 /dev/hdc /mnt/tmp via Host: 10.1.53.86} {returns: []}
{Cmd: mount |grep /dev/hdc|head -1 via Host: 10.1.53.86} {returns: ['/dev/hdc on /mnt/tmp type iso9660 (ro)']}
{Cmd: du /dev/hdc | tail -1 via Host: 10.1.53.86} {returns: ['0\t/dev/hdc']}
{Cmd: umount /mnt/tmp via Host: 10.1.53.86} {returns: []}
{Cmd: mount |grep /dev/hdc|head -1 via Host: 10.1.53.86} {returns: []}
=== TestName: test_10_attachAndDetach_iso | Status : SUCCESS ===

=== TestName: test_11_destroy_vm_and_volumes | Status : SUCCESS ===

=== TestName: test_12_start_vm_multiple_volumes_allocated | Status : SUCCESS ===

=== Final results are now copied to: /marvin//MarvinLogs/test_vm_life_cycle_HAM8FF ===
[root@pr9315-t7075-kvm-rocky8-marvin marvin]# cat /marvin//MarvinLogs/test_vm_life_cycle_HAM8FF/results.txt 
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test VM will be migrated with it's root volume ... === TestName: test_01_migrate_VM_and_root_volume | Status : SUCCESS ===
ok
Test VM will be migrated with it's root volume ... === TestName: test_02_migrate_VM_with_two_data_disks | Status : SUCCESS ===
ok
Test VM will be migrated with it's root volume ... SKIP: VM Migration with Volumes is not supported on other than VMware
Test VM will be migrated with it's root volume ... SKIP: VM Migration with Volumes is not supported on other than VMware
Test VM will be migrated with it's root volume ... SKIP: VM Migration with Volumes is not supported on other than VMware
Test VM will be migrated with it's root volume ... SKIP: VM Migration with Volumes is not supported on other than VMware
Test secure VM migration ... === TestName: test_01_secure_vm_migration | Status : SUCCESS ===
ok
Test Non-secured VM Migration ... === TestName: test_02_unsecure_vm_migration | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_03_secured_to_nonsecured_vm_migration | Status : SUCCESS ===
ok
Test Non-secured VM Migration ... === TestName: test_04_nonsecured_to_secured_vm_migration | Status : SUCCESS ===
ok
Test the following for all found ovf templates: ... SKIP: Skipping test: Reason -  hypervisorNotSupported
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Force Stop Virtual Machine ... === TestName: test_01_stop_vm_forced | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test Force Reboot Virtual Machine ... === TestName: test_04_reboot_vm_forced | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... === TestName: test_08_migrate_vm | Status : SUCCESS ===
ok
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test for attach and detach ISO to virtual machine ... === TestName: test_10_attachAndDetach_iso | Status : SUCCESS ===
ok
Test destroy Virtual Machine and it's volumes ... === TestName: test_11_destroy_vm_and_volumes | Status : SUCCESS ===
ok
Test attaching multiple datadisks and start VM ... === TestName: test_12_start_vm_multiple_volumes_allocated | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 26 tests in 1770.170s

OK (SKIP=5)

How did you try to break this feature and the system with this change?

Fixes apache#10120 When an uploaded volume is attached to a VM for which no existing volume can be found it was resulting in error. For such volumes, server needs to find a suitable pool first and copy them to the pool from secondary store. Signed-off-by: Abhishek Kumar <[email protected]>

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-02-04T10:37:11Z

@blueorangutan package

blueorangutan · 2025-02-04T10:38:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-02-04T10:44:03Z

Codecov Report

Attention: Patch coverage is 68.18182% with 21 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (802bf5f) to head (557b3ba).
Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	68.18%	18 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             4.19   #10324       +/-   ##
===========================================
+ Coverage        0   15.15%   +15.15%     
- Complexity      0    11313    +11313     
===========================================
  Files           0     5409     +5409     
  Lines           0   474664   +474664     
  Branches        0    57904    +57904     
===========================================
+ Hits            0    71935    +71935     
- Misses          0   394686   +394686     
- Partials        0     8043     +8043

Flag	Coverage Δ
uitests	`4.29% <ø> (?)`
unittests	`15.87% <68.18%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland

clgtm

blueorangutan · 2025-02-04T11:36:02Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12327

weizhouapache

code lgtm

@shwstppr
thanks for the quick fix

DaanHoogland · 2025-02-04T14:04:15Z

@blueorangutan test

blueorangutan · 2025-02-04T14:06:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-02-05T04:14:04Z

[SF] Trillian test result (tid-12306)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48183 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10324-t12306-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	`Error`	499.08	test_vm_life_cycle.py
test_12_start_vm_multiple_volumes_allocated	`Error`	17.37	test_vm_life_cycle.py

shwstppr · 2025-02-05T09:01:32Z

@blueorangutan package

blueorangutan · 2025-02-05T09:02:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

code looks good, let's test ;)

blueorangutan · 2025-02-05T10:06:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12339

DaanHoogland · 2025-02-05T10:52:23Z

@shwstppr , is this one ready or awaiting further improvements pending the revert of #10267 ?

shwstppr · 2025-02-05T12:24:35Z

@DaanHoogland this is ready now. If we revert #10267 then I'll add commits from that here

shwstppr · 2025-02-06T04:47:48Z

@blueorangutan test

blueorangutan · 2025-02-06T04:50:03Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Fixes issue highlighted in apache#9315 (comment) Signed-off-by: Abhishek Kumar <[email protected]>

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2025-02-06T10:38:26Z

@blueorangutan package

blueorangutan · 2025-02-06T10:40:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-06T11:41:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12363

weizhouapache · 2025-02-06T13:03:30Z

@blueorangutan test

blueorangutan · 2025-02-06T13:04:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-02-06T18:19:05Z

[SF] Trillian test result (tid-12321)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46085 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10324-t12321-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2025-02-06T18:21:49Z

[SF] Trillian test result (tid-12321)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46085 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10324-t12321-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Looks fine
@shwstppr @DaanHoogland

blueorangutan · 2025-02-07T02:30:15Z

[SF] Trillian test result (tid-12329)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10324-t12329-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

kiranchavala

LGTM, tested the volume upload scenario and its working fine ,
Also, Able to attach volume in allocated state

Smoke test also passed successfully

Launch 2 Cloudstack instances (vm1 and vm2) with only root disk in the same admin account.
Stop the instances (vm1 and vm2) and detach the root disk associated with the vm's (vm1 and vm2)
Download the root disk of vm1 to you local desktop
Upload the root disk of vm1 to the admin account. The state of the volume will be in Uploaded state
Attach the uploaded root disk of vm 1 to vm 2(Make sure to attach it as device id 0)
Uploaded volume attached successfully

shwstppr added 5 commits January 24, 2025 17:50

fix

af21605

Signed-off-by: Abhishek Kumar <[email protected]>

Merge remote-tracking branch 'apache/4.19' into fix-volattach-uploaded

0c6b243

fix

da6af2f

Signed-off-by: Abhishek Kumar <[email protected]>

add unit tests

4c1548a

Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:storage label Feb 4, 2025

DaanHoogland added this to the 4.19.2 milestone Feb 4, 2025

DaanHoogland approved these changes Feb 4, 2025

View reviewed changes

weizhouapache approved these changes Feb 4, 2025

View reviewed changes

shwstppr mentioned this pull request Feb 5, 2025

Revert test of #10267 #10323

Merged

DaanHoogland mentioned this pull request Feb 5, 2025

[HEALTH] 4.19 LTS Health Check, please don't merge this! #9315

Draft

shwstppr requested review from weizhouapache and DaanHoogland February 5, 2025 09:02

DaanHoogland approved these changes Feb 5, 2025

View reviewed changes

shwstppr added 2 commits February 6, 2025 16:07

Merge branch 'fix-volattach-uploaded' into fix-attachvol-npe

9e20c90

server: fix pod retrieval during volume attach

8d95a51

Fixes issue highlighted in apache#9315 (comment) Signed-off-by: Abhishek Kumar <[email protected]>

changes for attaching allocated vol to a stopped vm

557b3ba

Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr force-pushed the fix-attachvol-npe branch from daa379e to 557b3ba Compare February 6, 2025 10:38

shwstppr marked this pull request as ready for review February 7, 2025 04:27

kiranchavala approved these changes Feb 7, 2025

View reviewed changes

DaanHoogland merged commit a627ab6 into apache:4.19 Feb 7, 2025
26 checks passed

DaanHoogland deleted the fix-attachvol-npe branch February 7, 2025 11:59

server: fix pod retrieval during volume attach #10324

server: fix pod retrieval during volume attach #10324

Uh oh!

Conversation

shwstppr commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Feb 4, 2025

Uh oh!

blueorangutan commented Feb 4, 2025

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 4, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Feb 4, 2025

Uh oh!

blueorangutan commented Feb 4, 2025

Uh oh!

blueorangutan commented Feb 5, 2025

Uh oh!

shwstppr commented Feb 5, 2025

Uh oh!

blueorangutan commented Feb 5, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Feb 5, 2025

Uh oh!

DaanHoogland commented Feb 5, 2025

Uh oh!

shwstppr commented Feb 5, 2025

Uh oh!

shwstppr commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

shwstppr commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

weizhouapache commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

weizhouapache commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 7, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shwstppr commented Feb 4, 2025 •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading